20 Feb '12, 5pm
Nice. A solid lead on the 1.9.3 + Nokogiri SEGV I've been seeing: https://t.co/4OHKWXVX /ht @tenderlove @flavorjones
Hello ruby-core, I need help understanding why my patch for a Nokogiri issue /seems/ to fix a SEGV under 1.9.3. I've tested my patch for ~24 hours already with no failures, but I still do not understand why my patch can fix the issue, so I am uncomfortable with my change. I've reproduced the original issue on both 1.9.3-p0 and p105 on x86_64-linux. It can take a minute to an hour to hit the SEGV. It does not appear to manifest on 1.9.2, so maybe it is a bad interaction with lazy-sweep in 1.9.3 The goal of the code I'm changing is to ensure the document object associated with a node is marked if the node is still alive: http://bogomips.org/nokogiri.git/patch/?id=a1b7f1eef74ac9d69900488a56ba96ae9144615d The SEGV was caused by attempting to mark an already-freed document object associated with a node. I'm not sure how Nokogiri would allow document to get freed while nodes sti...