60% of the time, I replace conditionals with polymorphism every time:

Refactoring: Replace Conditional with Polymorphism

60% of the time, I replace conditionals with polymorphism every time:

Maintainability: we now had two ways of looking for error messages: from the errors collection, and from an exception raised during validation. This commit makes it clear that at least six places need to change if we add any more. Maintainability: this commit revealed that AllowValueMatcher had too many concerns: it both finds error messages to check, and parses the options and errors to determine whether or not the errors were expected. Readability: AllowValueMatcher is now too large to understand at a glance, weighing in at 26 methods. Readability: having two logical paths for every method resulted in a lot of long method names. In addition, having so many methods makes it more difficult to reduce the vertical distance between a method and the methods that reference it. Testability: making sure that the various forks work as expected requires testing everything in AllowV...

Full article: http://robots.thoughtbot.com/post/31728620503/refactoring...

Tweets

@thiagoarrais » 03 Oct '12, 1pm
Dissecting a refactoring: [link]
@Vladiim » 26 Sep '12, 9pm
Excellent refactoring walk through by @joeferris [link] #Ruby #Refactoring
@BrianTRice » 22 Sep '12, 2pm
RT @SeanTAllen: "Refactoring: Replace Conditional with Polymorphism" => [link]
@millisami » 21 Sep '12, 12pm
RT @zoraslapen: Refactoring: Replace Conditional with Polymorphism [link]
@DevWithPurpose » 20 Sep '12, 2pm
Jeremy: "Refactoring: Replace Conditional with Polymorphism" [link] via @thoughtbot // What do you think?
@bbonamin » 20 Sep '12, 1pm
RT @cristianrasch: What's better to kick off this morning than a great refactoring story, right? [link]
@cristianrasch » 20 Sep '12, 1pm
What's better to kick off this morning than a great refactoring story, right? [link]
@maurogeorge » 19 Sep '12, 5pm
Refactoring: Replace Conditional with Polymorphism [link] muito bom o artigo
@rafschmid » 19 Sep '12, 6am
RT @codepoet_ch: A lesson in refactoring from thoughbot. [link]
@roudi » 19 Sep '12, 5am
Refactoring: Replace Conditional with Polymorphism [link] via @prismatic
@featureenvy » 19 Sep '12, 3am
A lesson in refactoring from thoughbot. [link]
@CraigBuchek » 18 Sep '12, 8pm
cc @Adkron RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@thiagocifani » 18 Sep '12, 7pm
that is what I was talking about [link]
@samnangchhun » 18 Sep '12, 4pm
Refactoring: Replace Conditional with Polymorphism [link] via @thoughtbot
@ronaldofsousa » 18 Sep '12, 3pm
Refactoring: Replace Conditional with Polymorphism [link] #ruby #refactoring
@jyurek » 18 Sep '12, 1pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@thoughtbot » 18 Sep '12, 1pm
60% of the time, I replace conditionals with polymorphism every time: [link]
@HackerYolk » 17 Sep '12, 7pm
Refactoring: Replace Conditional with Polymorphism - [link] /HN
@pat_shaughnessy » 17 Sep '12, 5pm
.@joeferris shows us how he refactored something using a series of very small steps with passing tests: [link]
@planetonrails » 17 Sep '12, 4pm
Refactoring: Replace Conditional with Polymorphism [link]
@madtrick » 19 Sep '12, 1pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@jimrowe » 19 Sep '12, 11am
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@lsdr » 19 Sep '12, 3am
[link] - Refactoring: Replace Conditional with Polymorphism
@lucashungaro » 19 Sep '12, 12am
Refactoring: Replace Conditional with Polymorphism [link]
@dasch » 18 Sep '12, 6pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@rmoliva » 18 Sep '12, 3pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@golovko » 18 Sep '12, 3pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@hellocodes » 18 Sep '12, 3pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@soulcutter » 18 Sep '12, 3pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@thiagocifani » 18 Sep '12, 3pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@sobrinho » 18 Sep '12, 2pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@igmarin » 18 Sep '12, 1pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@MattRogish » 18 Sep '12, 1pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@Seivanheidari » 18 Sep '12, 1pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@DevWithPurpose » 18 Sep '12, 1pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@jmmcduffie » 18 Sep '12, 1pm
RT @thoughtbot: 60% of the time, I replace conditionals with polymorphism every time: [link]
@wPGnews » 18 Sep '12, 11am
Refactoring: Replace Conditional with Polymorphism [link]
@rbudiharso » 18 Sep '12, 2am
Refactoring: Replace Conditional with Polymorphism [link]